chore(jalai.py): cleanup the code - #140
Merged
Merged
Conversation
* Remove unneeded global statements. * Remove unneeded intermediate variable declarations. * Do not call int on floor division result. This is not needed in Python 3. Floor division always returns an integer in Python 3. * Use augmented arithmetic assignments (%=, -=, etc.) when possible. * Add a test for conversion on leap gregorian years. I noticed that there are no tests for this particular situation.
Contributor
Author
|
Some changes are perhaps a little subjective. Feel free to reject if the old code looks more readable to you. |
hramezani
approved these changes
Jul 24, 2023
hramezani
left a comment
hramezani
left a comment
Collaborator
There was a problem hiding this comment.
I didn't check it in detail but in general LGTM 👍
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an integer in Python 3.