feat(datetime): implement fromisoformat method - #136
Merged
Merged
Conversation
Improve `date.isoformat` so it will accept a new Python 3.11 format (with no `-` separator). Note: I have not implemented ISO week date formats because it looked too complicated and I have not seen it being used for Solar Hijri dates. closes #134
Owner
|
Thanks! we have had running our code on https://ci.appveyor.com/project/slashmili/python-jalali but it's broken for quite some time! |
Owner
|
The change you made is running on windows https://ci.appveyor.com/project/slashmili/python-jalali/builds/46626915 |
Owner
|
Published as 4.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve
date.isoformatso it will accept a new Python 3.11format (with no
-separator).Note: I have not implemented ISO week date formats because it looked
too complicated and I have not seen it being used for Solar Hijri dates.
closes #134