tests(test_zoneinfo_as_timezone): skip if tzinfo is not available on … - #135
Merged
Merged
Conversation
…windows On Windows, zoneinfo relies on tzinfo and without it the tests fail with import error. Also, rewrite pickle file loading. Previously `open` was using a relative path, which means the path used to depend on the current working directory and could fail if tests were triggered from a wrong directory. The new load_pickle function will handle that.
import it as _, so that no name conflict occurs at line 750.
Owner
|
@5j9 / @hramezani do you know how to fix the build in windows? https://ci.appveyor.com/project/slashmili/python-jalali If we want to apply this changes, I'd rather to fix the appveyor as well. |
slashmili
self-requested a review
March 28, 2023 10:18
Contributor
Author
|
@slashmili I just triggered an Appveyor build for this commit and it worked fine: https://ci.appveyor.com/project/5j9/python-jalali I read somewhere that this particular error may occur if Appveyor's authorization to read your Github account has expired. You may need to revoke the Github access by going to https://ci.appveyor.com/authorizations and then reauthorize it. |
Owner
|
Thanks @5j9! It was indeed authorization issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…windows
On Windows, zoneinfo relies on tzinfo and without it the tests fail with import error.
Also, rewrite pickle file loading.
Previously
openwas using a relative path, which means the path used to depend on the current working directory and could fail if tests were triggered from a wrong directory.The new load_pickle function will handle that.