Add certVersion field to logs when logging the cert name in handshakes - #1359
Merged
Merged
Conversation
jasikpark
force-pushed
the
log-cert-version-in-handshake
branch
from
March 19, 2025 21:11
e4576f7 to
2e10e16
Compare
jasikpark
marked this pull request as ready for review
March 19, 2025 21:19
jasikpark
force-pushed
the
log-cert-version-in-handshake
branch
from
March 19, 2025 21:23
2e10e16 to
8591a4b
Compare
nbrownus
approved these changes
Mar 25, 2025
1 task
63 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to add the certificate version to logs as an additional field
certVersionwhere it makes sense.I'm not sure I've placed this everywhere it makes sense, and I'm not sure I've used the right data, so please give it a good look.
But I've figured deriving the cert version from the same data as the cert name and adding the logging where certName is added should minimize getting it wrong.
Looking good to me! 👍