fix: preserve original app name as manifest display name by srtaalej · Pull Request #521 · slackapi/slack-cli

srtaalej · 2026-05-04T20:04:27Z

Changelog

Fix: App manifest display names now preserve the original app name instead of using the kebab-case directory name during slack create.

Summary

Separates the directory name (kebab-case) from the manifest display name (original user input) during app creation
Manifest display names (display_information.name, bot_user.display_name, and Deno SDK Manifest({ name })) now preserve the user's original input instead of using the kebab-case directory name
package.json and pyproject.toml names remain kebab-case per npm/Python conventions

Behavior

$ slack create              # random name → path "vibrant-panther-540/", manifest "vibrant-panther-540"
$ slack create my-app       # path "my-app/", manifest "my-app"
$ slack create "My App"     # path "my-app/", manifest "My App"

Test plan

Test_App_UpdateDefaultProjectFiles validates manifest files get the display name while package.json/pyproject.toml keep kebab-case
Test_App_UpdateDefaultProjectFiles_WriteFileError covers the WriteFile error path
Test_RegexReplaceAppNameInManifest updated to reflect display name input
Manual: slack create "My App" → verify manifest display name is "My App", directory is my-app/, and package.json stays my-app

The display_information.name and bot_user.display_name fields in manifest files were set to the kebab-case directory name (e.g. "my-app") instead of a human-readable title case name (e.g. "My App").

codecov · 2026-05-04T20:07:11Z

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.27%. Comparing base (178670f) to head (240dccb).

Files with missing lines	Patch %	Lines
internal/pkg/create/create.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   71.30%   71.27%   -0.04%     
==========================================
  Files         222      222              
  Lines       18677    18678       +1     
==========================================
- Hits        13318    13313       -5     
- Misses       4184     4185       +1     
- Partials     1175     1180       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zimeg

@srtaalej Thanks for getting this started 👾 ✨

I'm hesitant on this approach and am wondering if we instead separate how arguments and flags are parsed at this point?

Some issues I ran into are in comments but I'd like to share how I think about the "create" command:

$ slack create           # Generates a random app name as current
$ slack create my-app    # Keeps path "my-app" and manifest "my-app"
$ slack create "my App"  # Uses path "my-app" and manifest "my App"

🧰 Additional cases might complicate this but it's a good time to untangle this perhaps? I'm curious also if adding the --outdir flag makes parts of this more clear, while still supporting the happiest path simple cases?

zimeg · 2026-05-04T20:26:05Z

+
 // UpdateDefaultProjectFiles should update any project specific files if any
 func UpdateDefaultProjectFiles(fs afero.Fs, dirPath string, appDirName string) error {
+	displayName := kebabToTitleCase(appDirName)


🔍 issue: We might want to avoid changing the app name format altogether if this is provided in flags? Forgive me if I'm not understanding requirements right, but this app manifest for example might break with replacements:

Translator - Translate Languages

🔗 https://slack.com/marketplace/A8KHN4EDV-translator-translate-languages

zimeg · 2026-05-04T20:27:47Z

+
 // UpdateDefaultProjectFiles should update any project specific files if any
 func UpdateDefaultProjectFiles(fs afero.Fs, dirPath string, appDirName string) error {
+	displayName := kebabToTitleCase(appDirName)


🐍 ramble: Apps I keep might not fare well for additional example: "TIM", "TOM", or "snaek" have strange cases.

…ebab Addresses review feedback — instead of converting the kebab-case directory name to title case (which mangles names like "TIM" or "Translator - Translate Languages"), pass the original user-provided app name through to manifest display fields. This preserves the user's exact casing and formatting.

zimeg

@srtaalej This is running alright but I'm not certain the expected behavior matches the PR description and title since IIRC we're now avoiding title case defaults?

Leaving a few thoughts before approving and I also think a changelog toward this is best? Perhaps a standalone "bug" label too unless new featuresets are included too?

zimeg · 2026-05-07T18:49:21Z


 	// Update default project files' app name, bot name, etc
-	if err := app.UpdateDefaultProjectFiles(clients.Fs, projectDirPath, appDirName); err != nil {
+	if err := app.UpdateDefaultProjectFiles(clients.Fs, projectDirPath, appDirName, createArgs.AppName); err != nil {


🌟 praise: Nice! Keeping these separate makes it much easier to think about for me!

zimeg · 2026-05-07T18:52:08Z

+		{"package.json", regexReplaceAppNameInPackageJSON, appDirName},
+		{"pyproject.toml", regexReplaceAppNameInPyprojectToml, appDirName},


🧠 praise: Nice separation for project titles!

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

srtaalej · 2026-05-07T20:21:56Z

@zimeg updated the pr description and tests!

zimeg

@srtaalej Thanks for polish toward the create command 🦋

One question and hoping if this is toward next release let's include a changelog entry with the milestone 🚀 🔮

zimeg · 2026-05-08T08:57:29Z

-		"WriteFile error": {
-			appDirName: "vibrant-butterfly-1234",
-			existingFiles: map[string]string{
-				"manifest.json": string(testdata.ManifestJSON),
-			},
-			expectedFiles: map[string]string{
-				"manifest.json": string(testdata.ManifestJSONAppName),
-			},
-			expectedErrorType: nil,
-		},


📠 question: Was this case patched? It's not clear to me why the test is removed?

that test case is identical to the "manifest.json file exists" test case - i removed it because it was redundant

i will add a test case that actually produces the write file error separately

fix: use title case for manifest display names during app creation

7e47fee

The display_information.name and bot_user.display_name fields in manifest files were set to the kebab-case directory name (e.g. "my-app") instead of a human-readable title case name (e.g. "My App").

srtaalej requested a review from a team as a code owner May 4, 2026 20:04

zimeg requested changes May 4, 2026

View reviewed changes

srtaalej self-assigned this May 5, 2026

srtaalej requested a review from zimeg May 7, 2026 17:50

zimeg reviewed May 7, 2026

View reviewed changes

srtaalej changed the title ~~fix: use title case for manifest display names~~ fix: preserve original app name as manifest display name May 7, 2026

srtaalej and others added 2 commits May 7, 2026 15:20

Update test/testdata/manifest-app-name.ts

e0c3bb0

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

liinter errors

39cdaad

srtaalej requested a review from zimeg May 7, 2026 20:22

srtaalej added the changelog Use on updates to be included in the release notes label May 7, 2026

srtaalej mentioned this pull request May 7, 2026

fix: preserve path separators in create command argument #526

Open

5 tasks

zimeg approved these changes May 8, 2026

View reviewed changes

srtaalej and others added 2 commits May 8, 2026 10:34

Merge branch 'main' into ale-fix-display-name-casing

0a2a5fc

test: add WriteFile error test for UpdateDefaultProjectFiles

240dccb

srtaalej added this to the Next Release milestone May 8, 2026

srtaalej merged commit 52ea60b into main May 8, 2026
8 checks passed

srtaalej deleted the ale-fix-display-name-casing branch May 8, 2026 15:22

srtaalej added a commit that referenced this pull request May 8, 2026

merge: resolve conflict with main after PR #521

eed95a8

		{"package.json", regexReplaceAppNameInPackageJSON, appDirName},
		{"pyproject.toml", regexReplaceAppNameInPyprojectToml, appDirName},

Conversation

srtaalej commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Summary

Behavior

Test plan

Uh oh!

codecov Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg May 4, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg May 4, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zimeg May 7, 2026

Choose a reason for hiding this comment

Uh oh!

srtaalej commented May 7, 2026

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg May 8, 2026

Choose a reason for hiding this comment

Uh oh!

srtaalej May 8, 2026

Choose a reason for hiding this comment

Uh oh!

srtaalej May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

srtaalej commented May 4, 2026 •

edited

Loading

codecov Bot commented May 4, 2026 •

edited

Loading