Repository navigation
Fix #719 Enable developers to customize the way to handle unmatched requests - #741
Merged
Merged
Conversation
…atched requests
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
============================================
+ Coverage 77.29% 77.37% +0.07%
- Complexity 3283 3302 +19
============================================
Files 368 370 +2
Lines 9721 9771 +50
Branches 928 933 +5
============================================
+ Hits 7514 7560 +46
- Misses 1657 1659 +2
- Partials 550 552 +2
Continue to review full report at Codecov.
|
mwbrooks
approved these changes
May 10, 2021
mwbrooks
left a comment
Member
There was a problem hiding this comment.
Looks good! I really like the ListenerCodeSuggestion implementation 👍🏻
4 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #719 by adding new option named
unmatchedRequestHandlerinAppConfig.Also, I've added code snippet suggestion in the unmatched pattern warning logs like we did in Python slackapi/bolt-python#323
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.