Skip to content

Add filter to (multi_)conversations_select (also response_url_enabled) - #404

Merged
seratch merged 1 commit into
slackapi:masterfrom
seratch:conv-select-filters
Mar 19, 2020
Merged

seratch merged 1 commit into
slackapi:masterfrom
seratch:conv-select-filters

Conversation

@seratch

@seratch seratch commented Mar 18, 2020

Copy link
Copy Markdown
Contributor

Summary

This pull request adds filter to conversations_select / multi_conversations_select elements in input blocks. In addition to that, missing response_url_enabled in conversations_select / channels_select elements.

References:

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model labels Mar 18, 2020
@seratch seratch self-assigned this Mar 18, 2020
@codecov

codecov Bot commented Mar 18, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #404 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #404      +/-   ##
============================================
+ Coverage     83.91%   83.94%   +0.03%     
- Complexity     2344     2346       +2     
============================================
  Files           247      247              
  Lines          6317     6317              
  Branches        571      571              
============================================
+ Hits           5301     5303       +2     
+ Misses          668      666       -2     
  Partials        348      348              
Impacted Files Coverage Δ Complexity Δ
...m/slack/api/util/json/GsonBlockElementFactory.java 83.33% <0.00%> (+5.55%) 22.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18654e2...e9055b2. Read the comment docs.

@seratch
seratch force-pushed the conv-select-filters branch from b402727 to e9055b2 Compare March 19, 2020 00:55
@seratch

seratch commented Mar 19, 2020

Copy link
Copy Markdown
Contributor Author

For the Bolt framework side, I will send another pull request today.

@seratch
seratch merged commit 1663c7c into slackapi:master Mar 19, 2020
@seratch
seratch deleted the conv-select-filters branch March 19, 2020 01:16
@seratch seratch mentioned this pull request Mar 19, 2020
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant