Maintain metadata - #999
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 181 181
Lines 6312 6312
=======================================
Hits 5792 5792
Misses 520 520 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the implementation of slack-sdk#1436 it was found that the metadata from
pip show slack-boltwas not maintained in the changes introduced by #996This PR aims to remedy this situation by introducing changes that maintain the output of
pip show slack-boltOutput:
Name: slack-bolt Version: 1.18.1 Summary: The Bolt Framework for Python Home-page: https://github.com/slackapi/bolt-python Author: Slack Technologies, LLC Author-email: opensource@slack.com License: MIT Location: /.../env_3.11.2/lib/python3.11/site-packages Requires: slack-sdkThis package was also deployed to test.pypi/slack-bolt no behaviors were noticed
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.