Skip to content

Fix #988 app.action listener should accept block_id-only constraints for bolt-js feature parity - #990

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-988
Nov 21, 2023
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-988

Conversation

@seratch

@seratch seratch commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

This pull request resolves #988

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added the bug Something isn't working label Nov 21, 2023
@seratch seratch added this to the 1.18.1 milestone Nov 21, 2023
@seratch seratch self-assigned this Nov 21, 2023
@codecov

codecov Bot commented Nov 21, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (970956b) 91.77% compared to head (b227936) 91.76%.

Files Patch % Lines
slack_bolt/listener_matcher/builtins.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   91.77%   91.76%   -0.02%     
==========================================
  Files         181      181              
  Lines        6309     6312       +3     
==========================================
+ Hits         5790     5792       +2     
- Misses        519      520       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch
seratch merged commit 66812b3 into slackapi:main Nov 21, 2023
@seratch
seratch deleted the issue-988 branch November 21, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app.action listener should accept block_id-only constraints for bolt-js feature parity

1 participant