Skip to content

Clarify "Setting up events" section - #648

Merged
seratch merged 1 commit into
slackapi:mainfrom
hestonhoffman:patch-1
May 16, 2022
Merged

seratch merged 1 commit into
slackapi:mainfrom
hestonhoffman:patch-1

Conversation

@hestonhoffman

@hestonhoffman hestonhoffman commented May 16, 2022 •

Copy link
Copy Markdown
Contributor

This adds a few extra directions to help users find the **Subscribe to bot events" section.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

This adds a few extra directions to help users find the **Subscribe to bot events" section.
@CLAassistant

CLAassistant commented May 16, 2022 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@seratch seratch added the docs Improvements or additions to documentation label May 16, 2022
@seratch seratch added this to the 1.13.3 milestone May 16, 2022

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you @hestonhoffman 🙇🏻

@codecov

codecov Bot commented May 16, 2022

Copy link
Copy Markdown

Codecov Report

Merging #648 (f368c30) into main (b637c29) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #648   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files         170      170           
  Lines        5833     5833           
=======================================
  Hits         5371     5371           
  Misses        462      462           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b637c29...f368c30. Read the comment docs.

@seratch
seratch merged commit 4fef42d into slackapi:main May 16, 2022
seratch added a commit that referenced this pull request May 16, 2022
@seratch seratch modified the milestones: 1.13.3, 1.14.0 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants