Skip to content

Remove noqa comments and add __all__ to __init__.py files - #647

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:__all__
May 15, 2022
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:__all__

Conversation

@seratch

@seratch seratch commented May 14, 2022

Copy link
Copy Markdown
Contributor

This pull request removes # noqa ignore comments and adds __all__ to all the __init__.py files instead.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.13.3 milestone May 14, 2022
@seratch seratch self-assigned this May 14, 2022
@codecov

codecov Bot commented May 14, 2022

Copy link
Copy Markdown

Codecov Report

Merging #647 (8b2c16f) into main (8b10a02) will increase coverage by 0.03%.
The diff coverage is 98.19%.

@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
+ Coverage   92.04%   92.07%   +0.03%     
==========================================
  Files         170      170              
  Lines        5793     5833      +40     
==========================================
+ Hits         5332     5371      +39     
- Misses        461      462       +1     
Impacted Files Coverage Δ
slack_bolt/adapter/socket_mode/async_handler.py 0.00% <0.00%> (ø)
slack_bolt/__init__.py 100.00% <100.00%> (ø)
slack_bolt/adapter/aiohttp/__init__.py 46.66% <100.00%> (+3.80%) ⬆️
slack_bolt/adapter/aws_lambda/__init__.py 100.00% <100.00%> (ø)
slack_bolt/adapter/bottle/__init__.py 100.00% <100.00%> (ø)
slack_bolt/adapter/cherrypy/__init__.py 100.00% <100.00%> (ø)
slack_bolt/adapter/django/__init__.py 100.00% <100.00%> (ø)
slack_bolt/adapter/falcon/__init__.py 100.00% <100.00%> (ø)
slack_bolt/adapter/fastapi/__init__.py 100.00% <100.00%> (ø)
slack_bolt/adapter/fastapi/async_handler.py 100.00% <100.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b10a02...8b2c16f. Read the comment docs.

@seratch
seratch merged commit b637c29 into slackapi:main May 15, 2022
@seratch
seratch deleted the __all__ branch May 15, 2022 23:42
@seratch seratch modified the milestones: 1.13.3, 1.14.0 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants