Skip to content

Fix #639 is_enterprise_install does not exist in context object - #640

Merged
seratch merged 2 commits into
slackapi:mainfrom
seratch:issue-639-is_enterprise_install
Apr 29, 2022
Merged

seratch merged 2 commits into
slackapi:mainfrom
seratch:issue-639-is_enterprise_install

Conversation

@seratch

@seratch seratch commented Apr 29, 2022 •

Copy link
Copy Markdown
Contributor

This pull request resolves #639

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch self-assigned this Apr 29, 2022
@seratch seratch added bug Something isn't working area:async area:sync labels Apr 29, 2022
@seratch seratch added this to the 1.13.1 milestone Apr 29, 2022
@codecov

codecov Bot commented Apr 29, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #640 (616ec6a) into main (8df95d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage   92.03%   92.04%           
=======================================
  Files         170      170           
  Lines        5791     5792    +1     
=======================================
+ Hits         5330     5331    +1     
  Misses        461      461           
Impacted Files Coverage Δ
slack_bolt/__init__.py 100.00% <ø> (ø)
slack_bolt/adapter/django/handler.py 88.50% <ø> (ø)
slack_bolt/async_app.py 100.00% <ø> (ø)
slack_bolt/context/ack/internals.py 90.62% <ø> (ø)
slack_bolt/listener/builtins.py 100.00% <ø> (ø)
slack_bolt/middleware/ssl_check/ssl_check.py 93.10% <ø> (ø)
slack_bolt/oauth/internals.py 98.21% <ø> (ø)
slack_bolt/adapter/aws_lambda/__init__.py 100.00% <100.00%> (ø)
slack_bolt/adapter/bottle/__init__.py 100.00% <100.00%> (ø)
slack_bolt/adapter/cherrypy/__init__.py 100.00% <100.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319d000...616ec6a. Read the comment docs.

@seratch
seratch merged commit 27a01c1 into slackapi:main Apr 29, 2022
@seratch
seratch deleted the issue-639-is_enterprise_install branch April 29, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:async area:sync bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

is_enterprise_install does not exist in context object

1 participant