Repository navigation
Enable Flake8 in the CI builds - #638
Conversation
seratch
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #638 +/- ##
==========================================
- Coverage 92.03% 92.03% -0.01%
==========================================
Files 170 170
Lines 5791 5789 -2
==========================================
- Hits 5330 5328 -2
Misses 461 461
Continue to review full report at Codecov.
|
filmaj
left a comment
filmaj
left a comment
There was a problem hiding this comment.
👍
Nice branch name, I know what you played around with on your flight 👀
| python-version: ${{ matrix.python-version }} | ||
| - name: Run pytype verification | ||
| run: | | ||
| ./scripts/run_pytype.sh |
There was a problem hiding this comment.
Still seems like we run pytype in the CI?
There was a problem hiding this comment.
Ah, yes 🤦 Thanks for catching this.
Co-authored-by: Fil Maj <maj.fil@gmail.com>
| python-version: ${{ matrix.python-version }} | ||
| - name: Run pytype verification | ||
| run: | | ||
| ./scripts/run_pytype.sh |
There was a problem hiding this comment.
Ah, yes 🤦 Thanks for catching this.
|
@filmaj Thanks for your review! |
2 participants
This pull request enables Flake8 linter in the CI builds.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.