Skip to content

Upgrade pytype version to the latest - #636

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:pytype-upgrade
Apr 22, 2022
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:pytype-upgrade

Conversation

@seratch

@seratch seratch commented Apr 22, 2022 •

Copy link
Copy Markdown
Contributor

This pull request upgrades "pytype" code validator to 2022.4.15 plus updates the code to be compatible with the version.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added enhancement New feature or request area:sync labels Apr 22, 2022
@seratch seratch added this to the 1.13.1 milestone Apr 22, 2022
@seratch seratch self-assigned this Apr 22, 2022
@codecov

codecov Bot commented Apr 22, 2022

Copy link
Copy Markdown

Codecov Report

Merging #636 (e5676f4) into main (02c3520) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #636   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         170      170           
  Lines        5791     5791           
=======================================
  Hits         5333     5333           
  Misses        458      458           
Impacted Files Coverage Δ
slack_bolt/app/app.py 87.72% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c3520...e5676f4. Read the comment docs.

@seratch
seratch merged commit 0184e21 into slackapi:main Apr 22, 2022
@seratch
seratch deleted the pytype-upgrade branch April 22, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:sync enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant