Skip to content

Add Socket Mode healthcheck endpoint examples (#622) - #623

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-622-socket-mode-healthcheck
Mar 23, 2022
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-622-socket-mode-healthcheck

Conversation

@seratch

@seratch seratch commented Mar 23, 2022 •

Copy link
Copy Markdown
Contributor

This pull request provides examples in both async and sync apps for #622 question.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added docs Improvements or additions to documentation area:async area:adapter area:sync area:examples issues related to example or sample code labels Mar 23, 2022
@seratch seratch added this to the 1.13.1 milestone Mar 23, 2022
@seratch seratch self-assigned this Mar 23, 2022
@codecov

codecov Bot commented Mar 23, 2022

Copy link
Copy Markdown

Codecov Report

Merging #623 (46180df) into main (6c868f3) will not change coverage.
The diff coverage is n/a.

❗ Current head 46180df differs from pull request most recent head 4d1a37d. Consider uploading reports for the commit 4d1a37d to get more accurate results

@@           Coverage Diff           @@
##             main     #623   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         170      170           
  Lines        5791     5791           
=======================================
  Hits         5333     5333           
  Misses        458      458           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c868f3...4d1a37d. Read the comment docs.

@seratch seratch changed the title Fix #622 by adding Socket Mode healthcheck endpoint examples Add Socket Mode healthcheck endpoint examples (#622) Mar 23, 2022
@seratch
seratch merged commit cc194b7 into slackapi:main Mar 23, 2022
@seratch
seratch deleted the issue-622-socket-mode-healthcheck branch March 23, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:adapter area:async area:examples issues related to example or sample code area:sync docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant