Repository navigation
Improve oauth lambda deploy instructs - #621
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #621 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 170 170
Lines 5791 5791
=======================================
Hits 5333 5333
Misses 458 458 Continue to review full report at Codecov.
|
forfuncsake
reviewed
Mar 21, 2022
forfuncsake
reviewed
Mar 21, 2022
filmaj
approved these changes
Mar 21, 2022
filmaj
left a comment
filmaj
left a comment
Contributor
There was a problem hiding this comment.
Thanks a ton for this! Great work
seratch
approved these changes
Mar 22, 2022
seratch
left a comment
seratch
left a comment
Contributor
There was a problem hiding this comment.
Looks great to me! Added a few comments for the double-quote consistency.
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the oauth lambda app example instructions:
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsexamples/*changesRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.