Skip to content

Fix #617 Respect the configuration of logger parameter across App/AsyncApp loggers - #618

Merged
seratch merged 14 commits into
slackapi:mainfrom
seratch:issue-617-logger
Mar 18, 2022
Merged

seratch merged 14 commits into
slackapi:mainfrom
seratch:issue-617-logger

Conversation

@seratch

@seratch seratch commented Mar 18, 2022

Copy link
Copy Markdown
Contributor

This pull request resolves #617 by improving the internals of the package. This pull request adds base_logger argument to many constructors and methods but they are optional with default value None. Thus, the change does not bring any breaking changes to existing code.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.13.0 milestone Mar 18, 2022
@seratch seratch self-assigned this Mar 18, 2022
Comment thread slack_bolt/app/app.py Outdated
@codecov

codecov Bot commented Mar 18, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #618 (c19036c) into main (68eb2fe) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   91.46%   91.64%   +0.17%     
==========================================
  Files         170      170              
  Lines        5766     5791      +25     
==========================================
+ Hits         5274     5307      +33     
+ Misses        492      484       -8     
Impacted Files Coverage Δ
slack_bolt/adapter/aws_lambda/chalice_handler.py 84.28% <100.00%> (ø)
slack_bolt/adapter/aws_lambda/handler.py 95.83% <100.00%> (ø)
slack_bolt/app/app.py 87.72% <100.00%> (+0.02%) ⬆️
slack_bolt/app/async_app.py 94.20% <100.00%> (+0.01%) ⬆️
slack_bolt/listener/async_listener.py 98.41% <100.00%> (ø)
slack_bolt/listener/custom_listener.py 100.00% <100.00%> (ø)
...ck_bolt/listener_matcher/async_listener_matcher.py 96.55% <100.00%> (ø)
slack_bolt/listener_matcher/builtins.py 93.85% <100.00%> (+0.02%) ⬆️
...k_bolt/listener_matcher/custom_listener_matcher.py 100.00% <100.00%> (ø)
slack_bolt/logger/__init__.py 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68eb2fe...c19036c. Read the comment docs.

@seratch
seratch merged commit eda5574 into slackapi:main Mar 18, 2022
@seratch
seratch deleted the issue-617-logger branch March 18, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect the configuration of logger parameter across App/AsyncApp loggers

1 participant