Repository navigation
Fix #604 Respect the proxy_url in respond - #608
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
==========================================
+ Coverage 91.51% 91.52% +0.01%
==========================================
Files 169 169
Lines 5713 5723 +10
==========================================
+ Hits 5228 5238 +10
Misses 485 485
Continue to review full report at Codecov.
|
Contributor
Author
|
Hi reviewers, let me know if you have any comments on this 👋 I would like to release a new patch version for the reporter as early as possible. |
Contributor
Author
|
Confirmed that this issue does not exist in other Bolt frameworks (bolt-js, bolt-java). |
Contributor
Author
|
We are going to merge this PR and ship a new patch version tomorrow |
filmaj
approved these changes
Mar 2, 2022
filmaj
left a comment
filmaj
left a comment
Contributor
There was a problem hiding this comment.
Hey sorry for the late review! Yes this looks great, 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #604
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.