Skip to content

Fix #601 Allow for host option for AsyncSlackAppServer start method - #602

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-601
Feb 25, 2022
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-601

Conversation

@seratch

@seratch seratch commented Feb 25, 2022

Copy link
Copy Markdown
Contributor

This pull request resolves #601. With this change, developers can set a custom hostname over the default '0.0.0.0'.

from slack_bolt.async_app import AsyncApp
app = AsyncApp()
if __name__ == "__main__":
    app.start(3000, host='127.0.0.1')

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added enhancement New feature or request area:async labels Feb 25, 2022
@seratch seratch added this to the 1.11.5 milestone Feb 25, 2022
@seratch seratch self-assigned this Feb 25, 2022
@codecov

codecov Bot commented Feb 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #602 (a1915d4) into main (c0e98b0) will decrease coverage by 0.01%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
- Coverage   91.52%   91.51%   -0.02%     
==========================================
  Files         169      169              
  Lines        5709     5713       +4     
==========================================
+ Hits         5225     5228       +3     
- Misses        484      485       +1     
Impacted Files Coverage Δ
slack_bolt/app/async_app.py 94.19% <50.00%> (ø)
slack_bolt/app/async_server.py 51.06% <66.66%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e98b0...a1915d4. Read the comment docs.

@seratch

seratch commented Feb 25, 2022

Copy link
Copy Markdown
Contributor Author

@misscoded Thanks for the prompt review!

@seratch
seratch merged commit 52b1512 into slackapi:main Feb 25, 2022
@seratch
seratch deleted the issue-601 branch February 25, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:async enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for host option for AsyncSlackAppServer start method

2 participants