Repository navigation
Fix #584 Wrong user_token assigned to new user (affected versions: v1.11.2, v1.11.3) - #586
Merged
Merged
Conversation
….11.2, v1.11.3)
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #586 +/- ##
==========================================
+ Coverage 91.49% 91.53% +0.04%
==========================================
Files 169 169
Lines 5701 5707 +6
==========================================
+ Hits 5216 5224 +8
+ Misses 485 483 -2
Continue to review full report at Codecov.
|
seratch
commented
Feb 1, 2022
| context = BoltContext() | ||
| context["client"] = WebClient(base_url=self.mock_api_server_base_url) | ||
| result = authorize( | ||
| context=context, enterprise_id="E111", team_id="T0G9PQBBK", user_id="W333" |
Contributor
Author
There was a problem hiding this comment.
The installation store does not return tokens for user ID "W333"
| assert result.bot_id == "BZYBOTHED" | ||
| assert result.bot_user_id == "W23456789" | ||
| assert result.bot_token == "xoxb-valid" | ||
| assert result.user_token is None |
Contributor
Author
There was a problem hiding this comment.
Before the change in this PR, this is not absent.
| assert result.bot_id == "BZYBOTHED" | ||
| assert result.bot_user_id == "W23456789" | ||
| assert result.bot_token == "xoxb-valid-refreshed" | ||
| assert result.user_token is None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #584
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.