Repository navigation
Fix #468 Replying with 0 results for a multi-select external option display previous successful results - #580
Merged
Merged
Conversation
…isplay previous successful results
seratch
requested review from
filmaj,
misscoded,
mwbrooks,
srajiang and
stevengill
January 28, 2022 04:43
Codecov Report
@@ Coverage Diff @@
## main #580 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 169 169
Lines 5701 5701
=======================================
Hits 5216 5216
Misses 485 485
Continue to review full report at Codecov.
|
seratch
commented
Jan 28, 2022
| request = self.build_valid_multi_request() | ||
| response = app.dispatch(request) | ||
| assert response.status == 200 | ||
| assert response.body == """{"options": []}""" |
Contributor
Author
There was a problem hiding this comment.
Due to the bug, this response body used to be empty string "". That's why the select menu options are not updated in the reported scenario.
misscoded
approved these changes
Jan 28, 2022
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #468, which is a bolt-python bug for a long time.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.