Skip to content

Add more org-wide installation patterns to the SDK tests - #578

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:add-org-wid-tests
Jan 25, 2022
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:add-org-wid-tests

Conversation

@seratch

@seratch seratch commented Jan 25, 2022

Copy link
Copy Markdown
Contributor

This pull request adds more unit tests and code comments about org-wide installation patterns.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov

codecov Bot commented Jan 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #578 (0dab1a0) into main (cb3891b) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   91.48%   91.49%           
=======================================
  Files         169      169           
  Lines        5699     5701    +2     
=======================================
+ Hits         5214     5216    +2     
  Misses        485      485           
Impacted Files Coverage Δ
slack_bolt/request/internals.py 93.52% <50.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb3891b...0dab1a0. Read the comment docs.

@seratch
seratch merged commit 8c0532d into slackapi:main Jan 25, 2022
@seratch
seratch deleted the add-org-wid-tests branch January 25, 2022 13:22
@seratch seratch changed the title Add org-wide installation test patterns Add more org-wide installation patterns to the SDK tests Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant