Repository navigation
Fix cookie extraction during OAuth for REST based AWS API GW + Lambda app - #451
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #451 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 167 167
Lines 5499 5501 +2
=======================================
+ Hits 5023 5025 +2
Misses 476 476
Continue to review full report at Codecov.
|
seratch
approved these changes
Aug 28, 2021
|
|
||
|
|
||
| def to_bolt_request(event) -> BoltRequest: | ||
| """Note that this handler supports only the payload format 2.0. |
| cookies = multiValueHeaders.get("Cookie", []) | ||
| cookies = multiValueHeaders.get("cookie", []) | ||
| if len(cookies) == 0: | ||
| # Try using uppercase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request is related to #379.
I too deployed a Bolt-python app to AWS Lambda, integrated with REST (format v1.0) based API GW. In the process of the verification of oauth redirect, the app could not be installed properly. Taking a look at the CloudWatch logs I could see the multivalueheader in the request had the key "cookie" instead of "Cookie" as is expected by "to_bolt_request".
After modifying the following line to account for lower case "cookie", everything worked fine:
I think the comment about
to_bolt_requestnot supporting REST API can now be removed because I tried and it worksCategory (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.