Repository navigation
Added basic lazy lambda example setup and deploy instructions - #442
Merged
Merged
Conversation
…vendor module import issues.
filmaj
changed the title
Codecov Report
@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 167 167
Lines 5499 5499
=======================================
Hits 5023 5023
Misses 476 476 Continue to review full report at Codecov.
|
seratch
approved these changes
Aug 11, 2021
seratch
left a comment
seratch
left a comment
Contributor
There was a problem hiding this comment.
Thank you! Having vendor directory used to work but perhaps, it's no longer compatible with the tool.
seratch
added
area:adapter
area:examples
Contributor
|
oops, I forgot to mention the OAuth example. We can update the vendor directory part for the example too. https://github.com/slackapi/bolt-python/blob/main/examples/aws_lambda/aws_lambda_oauth_config.yaml |
Contributor
Author
|
Sounds good, will do |
Contributor
Author
|
Opened #444 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed vendor module import issues; based on the Create python package with dependencies AWS docs for Lambda, any dependencies need to exist in the root of the package. The changes in this PR are the changes I needed to incorporate to help me run the lazy example. I also tried to document my setup journey in a README in this directory.
This PR is based on trying to help out with #440.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.