Skip to content

Fix a token rotation bug where a bot token is not refreshed if a user token does not exist #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 1 commit into from
Aug 11, 2021
Merged

Fix a token rotation bug where a bot token is not refreshed if a user token does not exist #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion slack_bolt/authorization/async_authorize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,10 @@ async def __call__(
installation.user_token,
)

if installation.user_refresh_token is not None:
if (
installation.user_refresh_token is not None
or installation.bot_refresh_token is not None
):
if self.token_rotator is None:
raise BoltError(self._config_error_message)
refreshed = await self.token_rotator.perform_token_rotation(
Expand Down
5 changes: 4 additions & 1 deletion slack_bolt/authorization/authorize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,10 @@ def __call__(
installation.bot_token,
installation.user_token,
)
if installation.user_refresh_token is not None:
if (
installation.user_refresh_token is not None
or installation.bot_refresh_token is not None
):
if self.token_rotator is None:
raise BoltError(self._config_error_message)
refreshed = self.token_rotator.perform_token_rotation(
Expand Down