Skip to content

make events in Japanese document clearer - #429

Merged
seratch merged 4 commits into
slackapi:mainfrom
Shoryu-N:fix-issue-427
Aug 8, 2021
Merged

seratch merged 4 commits into
slackapi:mainfrom
Shoryu-N:fix-issue-427

Conversation

@Shoryu-N

@Shoryu-N Shoryu-N commented Aug 7, 2021 •

Copy link
Copy Markdown
Contributor

This pull request fixes #427

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@CLAassistant

CLAassistant commented Aug 7, 2021 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@seratch seratch added the docs Improvements or additions to documentation label Aug 7, 2021
@seratch seratch added this to the 1.8.0 milestone Aug 7, 2021

@seratch seratch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this pull request! Can you check my comments?

Comment thread docs/_advanced/ja_lazy_listener.md Outdated
Comment thread docs/_advanced/ja_lazy_listener.md Outdated
@codecov

codecov Bot commented Aug 7, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #429 (d55e461) into main (8c978ae) will not change coverage.
The diff coverage is n/a.

❗ Current head d55e461 differs from pull request most recent head 020149a. Consider uploading reports for the commit 020149a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         167      167           
  Lines        5491     5491           
=======================================
  Hits         5017     5017           
  Misses        474      474           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c978ae...020149a. Read the comment docs.

Shoryu-N and others added 3 commits August 8, 2021 00:13
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@Shoryu-N
Shoryu-N requested a review from seratch August 7, 2021 15:16
@seratch
seratch merged commit 0692846 into slackapi:main Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Japanese: Make "events" in the document even clearer (#412)

3 participants