Skip to content

Add Japanese translation of "Getting started over HTTP" and "Getting started" documents - #426

Merged
seratch merged 2 commits into
slackapi:mainfrom
hirosassa:406-socket-mode-doc-ja
Aug 5, 2021
Merged

seratch merged 2 commits into
slackapi:mainfrom
hirosassa:406-socket-mode-doc-ja

Conversation

@hirosassa

@hirosassa hirosassa commented Aug 4, 2021 •

Copy link
Copy Markdown
Contributor

(Describe the goal of this PR. Mention any related Issue numbers)

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@hirosassa hirosassa changed the title addd socket mode and http document in japanese Add Japanese translation of "Getting started over HTTP" and "Getting started" documents Aug 4, 2021
@codecov

codecov Bot commented Aug 4, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #426 (48de3c1) into main (eef1126) will not change coverage.
The diff coverage is n/a.

❗ Current head 48de3c1 differs from pull request most recent head 217fba5. Consider uploading reports for the commit 217fba5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         167      167           
  Lines        5491     5491           
=======================================
  Hits         5017     5017           
  Misses        474      474           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef1126...217fba5. Read the comment docs.

@srajiang srajiang added the docs Improvements or additions to documentation label Aug 4, 2021
@srajiang srajiang added this to the 1.8.0 milestone Aug 4, 2021
@srajiang

srajiang commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

Woot, big thank you @hirosassa for this contribution 🙌 !
I will let @seratch take the lead in providing review on this.

@seratch seratch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hirosassa Thanks for submitting this awesome pull request! I hope you won't mind receiving these change requests 🙇

Comment thread docs/_tutorials/ja_getting_started_http.md Outdated
Comment thread docs/_tutorials/ja_getting_started_http.md Outdated
Comment thread docs/_tutorials/ja_getting_started.md Outdated
Comment thread docs/_tutorials/ja_getting_started.md Outdated
Comment thread docs/_tutorials/ja_getting_started.md Outdated
Comment thread docs/_tutorials/ja_getting_started.md Outdated
Comment thread docs/_tutorials/ja_getting_started.md Outdated
Comment thread docs/_tutorials/ja_getting_started.md Outdated
Comment thread docs/_tutorials/ja_getting_started.md Outdated
Comment thread docs/_tutorials/ja_getting_started.md Outdated
@seratch Thanks for your review! Suggested changes are applied.

Co-authored-by: Kazuhiro Sera <seratch@gmail.com>

@hirosassa hirosassa left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seratch Thanks for your review comments! Suggested changes are applied.

@seratch seratch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 👍

@seratch
seratch merged commit 0849168 into slackapi:main Aug 5, 2021
seratch added a commit that referenced this pull request Aug 5, 2021
@hirosassa
hirosassa deleted the 406-socket-mode-doc-ja branch August 5, 2021 08:13
@hirosassa

Copy link
Copy Markdown
Contributor Author

Thanks! 🚀

seratch added a commit that referenced this pull request Aug 7, 2021
seratch added a commit that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants