Skip to content

Fix #377 Better log messages for AsyncApp when a listener is missing - #403

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-377-better-log-for-async
Jul 14, 2021
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-377-better-log-for-async

Conversation

@seratch

@seratch seratch commented Jul 10, 2021

Copy link
Copy Markdown
Contributor

This pull request fixes #377 by improving the unmatched request logging for AsyncApp.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.7.0 milestone Jul 10, 2021
@codecov

codecov Bot commented Jul 10, 2021

Copy link
Copy Markdown

Codecov Report

Merging #403 (6f62dba) into main (dce45c5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files         167      167           
  Lines        5388     5389    +1     
=======================================
+ Hits         4936     4937    +1     
  Misses        452      452           
Impacted Files Coverage Δ
slack_bolt/logger/messages.py 90.69% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce45c5...6f62dba. Read the comment docs.

@seratch
seratch merged commit 149c354 into slackapi:main Jul 14, 2021
@seratch
seratch deleted the issue-377-better-log-for-async branch July 14, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better log messages for AsyncApp when a listener is missing (improvement to #323)

1 participant