Repository navigation
Update install page to avoid favicon downloads - #375
Merged
Merged
Conversation
|
|
Contributor
|
Hi @Bhavya6187, thank you very much for taking the time to make this contribution! We will merge this once the CI builds pass. |
seratch
approved these changes
Jun 10, 2021
Updating content length in tests to match the new length due to added tag.
Contributor
|
@Bhavya6187 Thanks for updating the tests 👍 |
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 167 167
Lines 5375 5375
=======================================
Hits 4921 4921
Misses 454 454
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the link tag to the install page, which stops the browser from making another call to get favicon.ico, which resets the state cookie. This resolves the issue discussed in #366
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.