Skip to content

Fix #346 Allow unfurl_media / unfurl_links in ack / respond - #363

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-346-ack-respond-more-options
Jun 3, 2021
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-346-ack-respond-more-options

Conversation

@seratch

@seratch seratch commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

This pull request fixes #346 . Refer to the issue for details.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:async area:sync labels Jun 3, 2021
@seratch seratch added this to the 1.6.1 milestone Jun 3, 2021
@seratch seratch self-assigned this Jun 3, 2021
@codecov

codecov Bot commented Jun 3, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #363 (7470e58) into main (3622b68) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   91.54%   91.55%   +0.01%     
==========================================
  Files         167      167              
  Lines        5367     5375       +8     
==========================================
+ Hits         4913     4921       +8     
  Misses        454      454              
Impacted Files Coverage Δ
slack_bolt/context/ack/ack.py 100.00% <ø> (ø)
slack_bolt/context/ack/async_ack.py 100.00% <ø> (ø)
slack_bolt/context/respond/async_respond.py 90.90% <ø> (ø)
slack_bolt/context/respond/respond.py 90.90% <ø> (ø)
slack_bolt/context/say/async_say.py 96.00% <ø> (ø)
slack_bolt/context/say/say.py 96.00% <ø> (ø)
slack_bolt/context/ack/internals.py 90.62% <100.00%> (+0.62%) ⬆️
slack_bolt/context/respond/internals.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3622b68...7470e58. Read the comment docs.

@seratch
seratch merged commit e6079cd into slackapi:main Jun 3, 2021
@seratch
seratch deleted the issue-346-ack-respond-more-options branch June 3, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:async area:sync bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow unfurl_media and unfurl_links args to be passed to respond and ack methods

2 participants