Skip to content

Fix #312 Type hint errors with pytype 2021.4.26 - #313

Merged
seratch merged 2 commits into
slackapi:mainfrom
seratch:issue-312-pytype-latest
Apr 29, 2021
Merged

seratch merged 2 commits into
slackapi:mainfrom
seratch:issue-312-pytype-latest

Conversation

@seratch

@seratch seratch commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

This pull request resolves #312 by updating some internals of the library code.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov

codecov Bot commented Apr 28, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #313 (d7765a4) into main (39194ae) will decrease coverage by 0.01%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   91.47%   91.45%   -0.02%     
==========================================
  Files         166      166              
  Lines        5266     5278      +12     
==========================================
+ Hits         4817     4827      +10     
- Misses        449      451       +2     
Impacted Files Coverage Δ
slack_bolt/request/async_request.py 91.42% <75.00%> (-2.12%) ⬇️
slack_bolt/request/request.py 94.11% <87.50%> (-2.55%) ⬇️
slack_bolt/oauth/async_callback_options.py 100.00% <100.00%> (ø)
slack_bolt/oauth/async_oauth_settings.py 100.00% <100.00%> (ø)
slack_bolt/oauth/oauth_settings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39194ae...d7765a4. Read the comment docs.

@seratch
seratch merged commit ad622e4 into slackapi:main Apr 29, 2021
@seratch
seratch deleted the issue-312-pytype-latest branch April 29, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typehint errors with pytype 2021.4.26

2 participants