Repository navigation
Fix #260 Enable to use respond utility in app.view listeners (only when response_urls exists) - #288
Conversation
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
comments for reviewers
| def build_async_context( | ||
| context: AsyncBoltContext, | ||
| payload: Dict[str, Any], | ||
| body: Dict[str, Any], |
There was a problem hiding this comment.
Just for consistency with internals.py. This method name does not start with _ but this is part of internals source file. I think it's safe to change the name in the next minor release as no one relies on the argument name.
| "app_installed_team_id": "T111", | ||
| "bot_id": "B111", | ||
| }, | ||
| "response_urls": [ |
There was a problem hiding this comment.
This is the field this pull request takes care of. This array can have an element only when a modal has a conversations_select block element with response_url_enabled: true option.
Codecov Report
@@ Coverage Diff @@
## main #288 +/- ##
==========================================
- Coverage 91.35% 91.32% -0.04%
==========================================
Files 164 164
Lines 5135 5151 +16
==========================================
+ Hits 4691 4704 +13
- Misses 444 447 +3
Continue to review full report at Codecov.
|
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
Very straight forward addition and clean implementation! 👌🏻
|
Thanks for the review! |
|
Can you share any example on how to implement this in python, even one response url will work @seratch ? |
3 participants
This pull request resolves #260 by enabling
respondutility in view_submission listeners. Check the issue for learning the goal.Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.