Repository navigation
Enable installation_store authorize to fallback to bots (prep for #254) - #287
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
==========================================
- Coverage 91.50% 91.47% -0.03%
==========================================
Files 160 160
Lines 5000 5010 +10
==========================================
+ Hits 4575 4583 +8
- Misses 425 427 +2
Continue to review full report at Codecov.
|
stevengill
approved these changes
Apr 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves
InstallationStoreAuthorizeandAsyncInstallationStoreAuthorizefor better installation data resolution as part of #254 feature addition.Even when all user installations are revoked, bot scope installation should exist as long as the app is not uninstalled in the workspace. This is the reason why this SDK recommends having two data tables - bots and user installations. This pull request improves the authorize functions to be capable to resolve bot installation regardless of the behavior of find_installation method in
InstallationStore/AsyncInstallationStore. Refer to the test code for learning what the use case is.Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.