Skip to content

Fix #267 Mention the necessity of lambda:InvokeFunction permission in lazy listener document - #286

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-267
Apr 9, 2021
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-267

Conversation

@seratch

@seratch seratch commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

This pull request resolves #267

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added the docs Improvements or additions to documentation label Apr 9, 2021
@seratch seratch added this to the 1.5.0 milestone Apr 9, 2021
@codecov

codecov Bot commented Apr 9, 2021

Copy link
Copy Markdown

Codecov Report

Merging #286 (9e7014b) into main (efab010) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 9e7014b differs from pull request most recent head c0eb1d0. Consider uploading reports for the commit c0eb1d0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   91.50%   91.52%   +0.01%     
==========================================
  Files         160      160              
  Lines        5000     5000              
==========================================
+ Hits         4575     4576       +1     
+ Misses        425      424       -1     
Impacted Files Coverage Δ
slack_bolt/listener/thread_runner.py 94.33% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efab010...c0eb1d0. Read the comment docs.

@seratch
seratch merged commit 12ce26a into slackapi:main Apr 9, 2021
@seratch
seratch deleted the issue-267 branch April 9, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mention the necessity of lambda:InvokeFunction permission in lazy listener document

2 participants