Skip to content

Fix #261 SocketModeHandler#start() does not terminate on Windows - #262

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-261-windows-socket-mode
Mar 22, 2021
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-261-windows-socket-mode

Conversation

@seratch

@seratch seratch commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

This pull request resolves #261 by adding an extra logic for Windows OS. Refer to https://bugs.python.org/issue35935 for details.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:adapter area:sync labels Mar 19, 2021
@seratch seratch added this to the 1.4.4 milestone Mar 19, 2021
@seratch seratch self-assigned this Mar 19, 2021
@codecov

codecov Bot commented Mar 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #262 (418506e) into main (dafc833) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head 418506e differs from pull request most recent head a59d1e0. Consider uploading reports for the commit a59d1e0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   91.28%   91.25%   -0.04%     
==========================================
  Files         160      160              
  Lines        4979     4983       +4     
==========================================
+ Hits         4545     4547       +2     
- Misses        434      436       +2     
Impacted Files Coverage Δ
slack_bolt/adapter/socket_mode/base_handler.py 62.96% <50.00%> (-2.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dafc833...a59d1e0. Read the comment docs.

@seratch
seratch merged commit de2ee3e into slackapi:main Mar 22, 2021
@seratch
seratch deleted the issue-261-windows-socket-mode branch March 22, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:adapter area:sync bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SocketModeHandler#start() does not terminate on Windows

1 participant