Repository navigation
Resolve #251 by correcting a duplicated response header - #253
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 91.37% 91.37%
=======================================
Files 160 160
Lines 4973 4973
=======================================
Hits 4544 4544
Misses 429 429
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #251 by correcting the set of response headers for OAuth flows.
Before the changes in this PR, this library's OAuth flow handler has been having the
content-lengthheader twice in a response. In actual fact, the response works with major browsers anyway. However, Google Cloud Run's server-side has a bit strict format validation policies before delivering an HTTP response. Due to the validation, the OAuth flow fails in the way described in the issue.If I remember correctly, there is no specific need to manually craft the header but I added the logic just for easily ensuring the compatibility with various adapters (sadly, it was not easy in this case...). As most web frameworks generates the header under the hood.
For this reason, I'm sure it's safe enough to delete the one created by this library. Also, I've already verified all the adapters including the AWS Lambda adapter work with this change.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.