Skip to content

Upgrade the minimum slack-sdk version to 3.4 - #243

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:bump-sdk-version
Feb 19, 2021
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:bump-sdk-version

Conversation

@seratch

@seratch seratch commented Feb 19, 2021

Copy link
Copy Markdown
Contributor

As we have improvements for proxy supports and stability of built-in SocketModeClient in slack-sdk v3.4, we set the minimum required version to the minor version. Also, we stop limiting the usage of newer minor versions since this version.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov

codecov Bot commented Feb 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #243 (50dbadf) into main (3bde6df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         160      160           
  Lines        4967     4967           
=======================================
  Hits         4538     4538           
  Misses        429      429           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bde6df...f33edac. Read the comment docs.

@seratch
seratch merged commit 0b7f28c into slackapi:main Feb 19, 2021
@seratch
seratch deleted the bump-sdk-version branch February 19, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant