Skip to content

Fix #232 Unmatched message listener middleware can be called - #233

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-232-message-listener-middleware
Feb 9, 2021
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-232-message-listener-middleware

Conversation

@seratch

@seratch seratch commented Feb 7, 2021

Copy link
Copy Markdown
Contributor

This pull request fixes a bug #232 where app.message listener's custom middleware can be called even when a listener's conditions do not match an incoming request. This has been a bug since pull request #41 has been merged (version 0.3).

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:async area:sync labels Feb 7, 2021
@seratch seratch added this to the 1.3.1 milestone Feb 7, 2021
@seratch seratch self-assigned this Feb 7, 2021
@codecov

codecov Bot commented Feb 7, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #233 (602fcdc) into main (2fd8674) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         160      160           
  Lines        4967     4967           
=======================================
  Hits         4538     4538           
  Misses        429      429           
Impacted Files Coverage Δ
slack_bolt/app/app.py 86.88% <100.00%> (ø)
slack_bolt/app/async_app.py 94.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd8674...4ba78a5. Read the comment docs.

@seratch
seratch merged commit 2d67290 into slackapi:main Feb 9, 2021
@seratch
seratch deleted the issue-232-message-listener-middleware branch February 9, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:async area:sync bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant