Skip to content

Doc event bolt python - #220

Merged
mwbrooks merged 2 commits into
slackapi:mainfrom
pdontha:doc-event-bolt-python
Jan 22, 2021
Merged

mwbrooks merged 2 commits into
slackapi:mainfrom
pdontha:doc-event-bolt-python

Conversation

@pdontha

@pdontha pdontha commented Jan 22, 2021

Copy link
Copy Markdown
Contributor

Fixed minor bugs for the syntax and event dict object in the examples.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • [ x] Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov

codecov Bot commented Jan 22, 2021

Copy link
Copy Markdown

Codecov Report

Merging #220 (7e240f0) into main (01894d7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         159      159           
  Lines        4769     4769           
=======================================
  Hits         4370     4370           
  Misses        399      399           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01894d7...7e240f0. Read the comment docs.

@mwbrooks mwbrooks added the docs Improvements or additions to documentation label Jan 22, 2021
@mwbrooks
mwbrooks requested review from mwbrooks and seratch January 22, 2021 22:29

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pdontha for helping to improve our documentation! I've previewed this update locally and it renders okay. LGTM :shipit:

@mwbrooks
mwbrooks merged commit cf3985d into slackapi:main Jan 22, 2021
@seratch seratch added this to the 1.3.0 milestone Jan 27, 2021
@seratch seratch mentioned this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants