Skip to content

Apply more updates on #216 - #217

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:pr-216-updates
Jan 20, 2021
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:pr-216-updates

Conversation

@seratch

@seratch seratch commented Jan 20, 2021

Copy link
Copy Markdown
Contributor

This pull request applies a few changes on top of #216

  • Rename name_for_callable to get_name_for_callable for consistent naming
  • Apply get_name_for_callable to listener.ack_function just in case

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov

codecov Bot commented Jan 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #217 (9f932d5) into main (f0ee5a1) will increase coverage by 0.00%.
The diff coverage is 86.36%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   91.62%   91.63%           
=======================================
  Files         159      159           
  Lines        4767     4769    +2     
=======================================
+ Hits         4368     4370    +2     
  Misses        399      399           
Impacted Files Coverage Δ
slack_bolt/listener/asyncio_runner.py 84.61% <50.00%> (ø)
slack_bolt/listener/thread_runner.py 89.62% <75.00%> (ø)
slack_bolt/app/app.py 86.78% <100.00%> (ø)
slack_bolt/app/async_app.py 94.70% <100.00%> (+0.01%) ⬆️
slack_bolt/middleware/async_custom_middleware.py 96.15% <100.00%> (ø)
slack_bolt/middleware/custom_middleware.py 100.00% <100.00%> (ø)
slack_bolt/util/utils.py 93.93% <100.00%> (-0.18%) ⬇️
slack_bolt/workflows/step/async_step_middleware.py 96.77% <100.00%> (+0.10%) ⬆️
slack_bolt/workflows/step/step_middleware.py 96.77% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ee5a1...9f932d5. Read the comment docs.

@seratch
seratch merged commit bbcad63 into slackapi:main Jan 20, 2021
@seratch
seratch deleted the pr-216-updates branch January 20, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant