You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Improvement related to #199: add event type name validation - #201
This pull request improves the event listener registration in the aim of helping developers easily understand what's wrong with message.* values for event types. ref #199
Category (place an x in each of the [ ])
slack_bolt.App and/or its core components
slack_bolt.async_app.AsyncApp and/or its core components
@aoberoi@stevengill@mwbrooks@misscoded
We may want to add the same validation to Bolt for JS and Bolt for Java. If there is no objection to it, I am happy to work on it.
As we do not have enough time until v1.2.0 release, I will be waiting for feedback for a few more days. If this is fine, I will merge this change for v1.2.1.
This pull request is ready to merge. I will wait for responses from other maintainers for a few more business days before merging it. For feature parity across SDKs, I started a discussion at slackapi/bolt-js#757
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the event listener registration in the aim of helping developers easily understand what's wrong with
message.*values for event types. ref #199Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.