Repository navigation
Fix #197 by supporting classic bot messages in app.message constraints - #198
Merged
seratch merged 1 commit intoJan 12, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #198 +/- ##
==========================================
- Coverage 92.14% 92.12% -0.03%
==========================================
Files 149 149
Lines 4496 4508 +12
==========================================
+ Hits 4143 4153 +10
- Misses 353 355 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
It seems no one has concerns on this change. Let me merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #197 by adding support for classic app's bot messages in
app.messagelistener constraints.When an app with the current permission model posts a message in a channel, Events API sends the following payload (Payload A) to your app. On the other hand, if a message is posted by a classic app, the Event API payload (Payload B) can be a bit different. The notable difference is the existence of "bot_message" subtype. Bolt for Python had not been including this pattern for the events that can be handled by
app.messagelisteners. This pull request resolves this issue.Payload A
Payload B
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.