Repository navigation
Fix #193 by enabling listener middleware to return a response - #194
Merged
seratch merged 2 commits intoJan 7, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 92.15% 92.10% -0.06%
==========================================
Files 149 149
Lines 4448 4470 +22
==========================================
+ Hits 4099 4117 +18
- Misses 349 353 +4
Continue to review full report at Codecov.
|
seratch
commented
Jan 6, 2021
| if next_was_not_called: | ||
| if middleware_resp is not None: | ||
| if self._framework_logger.level <= logging.DEBUG: | ||
| debug_message = debug_return_listener_middleware_response( |
Contributor
Author
There was a problem hiding this comment.
An example log message:
DEBUG slack_bolt.App:app.py:366 Responding with listener middleware's response - listener: handle, status: 200, body: listener middleware (3 millis)
| :param req: An incoming request from Slack. | ||
| :return: The response generated by this Bolt app. | ||
| """ | ||
| starting_time = time.time() |
Contributor
Author
There was a problem hiding this comment.
Debug logs used to track only the time spent in a listener function. Starting here is more accurate.
2 of 4 tasks
Ambro17
reviewed
Jan 6, 2021
| # This means the listener is not for this incoming request. | ||
| continue | ||
|
|
||
| if middleware_resp is not None: |
There was a problem hiding this comment.
This would be the case when a listener middleware sets the response but also calls next, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #193 by enabling listener middleware's behavior to return a response without running its listener function.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.