Repository navigation
Fix #183 Easier way to configure the direct install URL on App Directory - #186
Merged
seratch merged 5 commits intoJan 9, 2021
Merged
Conversation
Contributor
Author
|
I will rerun the build after merging #187 |
…nstall URL on App Directory
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 92.13% 92.14% +0.01%
==========================================
Files 149 149
Lines 4488 4496 +8
==========================================
+ Hits 4135 4143 +8
Misses 353 353
Continue to review full report at Codecov.
|
Contributor
Author
|
To reviewers, please let me know if you see something unclear for reviewing this (checking #183 should be helpful for learning the context and the reason behind this change). Considering the schedule for next minor version release, I would like to merge this change by the end of this week in my timezone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #183 for the context and details.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.