Repository navigation
Fix #158 by adding token_verification_enabled option to App - #180
Merged
seratch merged 1 commit intoDec 18, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 91.76% 91.77%
=======================================
Files 149 149
Lines 4446 4448 +2
=======================================
+ Hits 4080 4082 +2
Misses 366 366
Continue to review full report at Codecov.
|
mwbrooks
approved these changes
Dec 18, 2020
mwbrooks
left a comment
mwbrooks
left a comment
Member
There was a problem hiding this comment.
Nice! Looks good to me.
Should we also add this to Bolt for JavaScript and Java to keep feature parity?
Contributor
Author
@mwbrooks yes, let's do this 👍 |
4 of 10 tasks
Member
|
@seratch created an issue to track the work for Bolt JS - slackapi/bolt-js#718 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new option
token_verification_enabled: booltoAppconstructor arguments. The default value of this option isTrue. If it'sTrue, Bolt performsauth.testAPI call when instantiating anAppinstance. IfFalse, the initial call will be postponed until the first execution of the single team authorization middleware. Regardless of the timing of the initial call, the API response is cached as before.Due to the compatibility with async/await nature in Python,
AsyncAppdoes not verify a given token when creating a newAsyncAppinstance. Thus, this pull request does not apply any changes toAsyncApp.Fixes #158
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.