Skip to content

Remove the possibility of issue #170 by removing emoji from the boot message only for Windows - #173

Merged
seratch merged 2 commits into
slackapi:mainfrom
seratch:issue-170-windows
Dec 8, 2020
Merged

seratch merged 2 commits into
slackapi:mainfrom
seratch:issue-170-windows

Conversation

@seratch

@seratch seratch commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

This pull request adds a workaround for potential issues on Windows like #170 .

As long as a developer uses UTF-8 as the system's encoding, the issue described at #170 never happens (actually, I was not able to reproduce the issue on my personal Windows machine). That said, if a developer encounters #170, it can be a critical blocker for trying Bolt out.

This pull request simply removes the ⚡️ character from the boot message only when running the app on Windows OS. I like having the emoji in the message but it's more important to enable any developers to try this framework. If we could find a way to safely get the emoji back for Windows, I'm happy to have the additional updates to it.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.1.2 milestone Dec 6, 2020
@seratch seratch self-assigned this Dec 6, 2020
@seratch
seratch merged commit 256e47e into slackapi:main Dec 8, 2020
@seratch
seratch deleted the issue-170-windows branch December 8, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant