Repository navigation
Fix #165 by making AsyncApp compatible with aiohttp-devtools - #168
Conversation
| # pip install -r requirements.txt | ||
| # export SLACK_SIGNING_SECRET=*** | ||
| # export SLACK_BOT_TOKEN=xoxb-*** | ||
| # adev runserver --port 3000 --app-factory app_factory async_app.py |
There was a problem hiding this comment.
Check this example to learn how to use the devtool.
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 81.64% 81.65%
=======================================
Files 149 149
Lines 4403 4415 +12
=======================================
+ Hits 3595 3605 +10
- Misses 808 810 +2
Continue to review full report at Codecov.
|
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
To other maintainers, let me know your thoughts. I will merge this and will release a new patch version soon.
| self._server = AsyncSlackAppServer(port=port, path=path, app=self,) | ||
| return self._server | ||
|
|
||
| def web_app(self, path: str = "/slack/events") -> web.Application: |
There was a problem hiding this comment.
When you use aiohttp-devtools, specifying the port to listen on in code does not work. That's why I removed the arg in this factory method as it's so confusing if giving it here does not work.
3 participants
This pull request fixes #165 by providing a way to easily access
aiohttp.web.Applicationinstance.aiohttp-devtools:
https://github.com/aio-libs/aiohttp-devtools
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.