Skip to content

Upgrade black (code formatter) to the latest version - #167

Merged
seratch merged 2 commits into
slackapi:mainfrom
seratch:upgrade-black
Dec 19, 2020
Merged

seratch merged 2 commits into
slackapi:mainfrom
seratch:upgrade-black

Conversation

@seratch

@seratch seratch commented Dec 2, 2020

Copy link
Copy Markdown
Contributor

This pull request upgrades black version to the latest (from 19.10b0 to 20.8b1) and applies the formatter to all code in this project.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.1.1 milestone Dec 2, 2020
@seratch seratch self-assigned this Dec 2, 2020
@seratch seratch modified the milestones: 1.1.1, 1.1.2 Dec 2, 2020
@codecov-io

codecov-io commented Dec 2, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #167 (009e61c) into main (8efa2ba) will increase coverage by 0.00%.
The diff coverage is 89.18%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   91.76%   91.77%           
=======================================
  Files         149      149           
  Lines        4446     4448    +2     
=======================================
+ Hits         4080     4082    +2     
  Misses        366      366           
Impacted Files Coverage Δ
slack_bolt/adapter/aiohttp/__init__.py 42.85% <ø> (ø)
slack_bolt/adapter/aws_lambda/handler.py 92.42% <ø> (ø)
slack_bolt/adapter/pyramid/handler.py 89.18% <ø> (ø)
slack_bolt/adapter/sanic/async_handler.py 85.00% <0.00%> (ø)
slack_bolt/adapter/starlette/async_handler.py 87.09% <0.00%> (ø)
slack_bolt/adapter/starlette/handler.py 86.66% <0.00%> (ø)
slack_bolt/app/async_server.py 48.83% <ø> (ø)
slack_bolt/authorization/authorize.py 84.44% <ø> (ø)
slack_bolt/context/say/async_say.py 96.00% <ø> (ø)
slack_bolt/context/say/say.py 96.00% <ø> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd9279...009e61c. Read the comment docs.

@seratch seratch modified the milestones: 1.1.2, 1.1.3, 1.1.4 Dec 5, 2020
@seratch
seratch merged commit 809e255 into slackapi:main Dec 19, 2020
@seratch
seratch deleted the upgrade-black branch December 19, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants