Skip to content

Add OAuth related arg validation and flexibility - #153

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:oauth-improvements
Nov 24, 2020
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:oauth-improvements

Conversation

@seratch

@seratch seratch commented Nov 23, 2020 •

Copy link
Copy Markdown
Contributor

This pull request applies a few improvements to OAuthFlow and OAuthSettings (and their async ones).

  • Add type validations for AsyncOAuthFlow and AsyncOAuthSettings
  • Enable developers to pass a single str value to scopes and user_scopes in OAuthSettings / AsyncOAuthSettings

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.0.1 milestone Nov 23, 2020
@seratch seratch self-assigned this Nov 23, 2020
@seratch
seratch merged commit 5033ae4 into slackapi:main Nov 24, 2020
@seratch
seratch deleted the oauth-improvements branch November 24, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant