Docs: adds Docusaurus site - #1113
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 186 186
Lines 6408 6408
=======================================
Hits 5883 5883
Misses 525 525 ☔ View full report in Codecov by Sentry. |
zimeg
left a comment
There was a problem hiding this comment.
Nice!!!! 🤩 These are great changes and I'm a big fan of the build. It's exciting to have a bit more room for code snippets and expanded details for different pages.
Approving this now since I'm confident in these changes - thanks for sifting through so many files 🙏 - but think a few comments are worth checking out before merging.
🚀 Awesomeness in all of these changes and love how it all reads!
Co-authored-by: Eden Zimbelman <ethan.zimbelman@slack-corp.com>
WilliamBergamin
left a comment
There was a problem hiding this comment.
This is great work 💯
Do you think we can safely remove scripts/run_jekyll.sh?
Also what do you think about enabling dependabot for this directory I think adding the following in .github/dependabot.yml should be sufficient
- package-ecosystem: "npm"
directory: "/docs"
schedule:
interval: "monthly"Co-authored-by: William Bergamin <wbergamin@salesforce.com>
WilliamBergamin
left a comment
There was a problem hiding this comment.
Thanks for the changes 💯
Found one more line to address but then we should be good to ship 🚢
Co-authored-by: William Bergamin <wbergamin@salesforce.com>
Category
/docsRequirements
./scripts/install_all_and_run_tests.shafter making the changes.Summary
This is the new Docusaurus site. Tested that it builds properly.
This is less absurdly large then it looks! ~15,000 of the changed lines are
package-lock.json😬 . Most of the files are from moving stuff around (I usedgit mv!). I talked to @WilliamBergamin about moving the generated docs -- the reference docs are going in/docs/staticnow instead of/docs.Speaking of those reference docs... they don't work with
npm run startornpm run build/serve. It doesn't like the.htmllinks being explicit. BUT it works in production. I tested out a page on my personal repo. Weird stuff. I wasted a a few days of my life on thatAnyway, there are about only a few files in this PR that matter for review:
Maintenance files:
Site config files:
The 404 page has two files, for Docusaurus ~ reasons ~
Folder and file organization
This shares the same structure as the other sites. At large:
The default name for my
contentfolder wasdocsbutdocs/docswas silly. I am open to other names though.Docs pages: slugs and links
The organization of pages is purposefully kept as similar to the current layout of pages so developers don't get jarred from both a site change and page changes. Slugs are all named matching that previous organization - i.e. something in the
basicsor theadvancedfolder (and others) has theconceptsslug:/bolt-python/concepts/authorization. This is slightly different than the previous site, which took the form of/bolt-python/concepts#authorization. They're all separate pages, not headers now.All
.mdfiles were renamed (yes, I usedgit mv) to match the title and the slug. Everything now matches up.All markdown reference links were also updated to be up-to-date and working. If it's a link on the site, it now works. I also stripped all the pages of any residual HTML or custom formatting. They should all be the most basic of markdown now.
Editing and managing the site
The README contains a basic docs editing guide. You don't need to worry about the site unless you're touching something inside the
/docsfolder.There is a new action workflow: it does a test build on docs PRs and deploys the site on merges to main.
Next steps
This wouldn't be a DevRel project without some fast follows. This is what I plan on doing after all the sites are live:
custom.cssif the main site'scustom.cssis changed.